Implement Debug
w/ detailed manifest for Reader
#473
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Store
field toManifestStore
to open access to allStore
methods and allow constructing aManifestStoreReport
on the flyDebug
forReader
, providing the user with detailed debug information about the manifest (effectively exposingManifestStoreReport
in the unstable API)Notes
Reader
already implementsDisplay
, providing user-friendly information about the manifest, whereasDebug
provides detailed info viaManifestStoreReport
.ManifestStoreReport::dump_tree
andManifestStoreReport::cert_chain
in the unstable API?Manifest::certificates
, could be usefulChecklist
TO DO
items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.