Skip to content

Make effect peerDependency #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikearnaldi opened this issue Oct 11, 2021 · 1 comment
Closed

Make effect peerDependency #6

mikearnaldi opened this issue Oct 11, 2021 · 1 comment

Comments

@mikearnaldi
Copy link

Effect is currently loaded via utils as a dependency while it should be loaded as peerDependency. Linking libs as deps is generally unadvisable for any dependency but poses a critical risk for effect (and its ecosystem packages) in particular given that it doesn't work if multiple copies are loaded.

https://github.com/contentlayerdev/contentlayer/blob/main/packages/%40contentlayer/utils/package.json#L43

Note that multiple copies will be loaded any time a user of the lib installs a different version of effect (even a patch) in a child project, that isn't the case for peerDependencies with a set range of acceptable versions

schickling added a commit that referenced this issue Nov 3, 2021
@schickling
Copy link
Collaborator

schickling commented Nov 3, 2021

Addressed by 7193a37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants