fix: harden JetBrains remote config sync to prevent IDE freezes#11891
Merged
fix: harden JetBrains remote config sync to prevent IDE freezes#11891
Conversation
Remove Sentry error reporting from the sync catch block — the service<ContinueSentryService>() call could itself throw from the background thread, letting the original exception escape and silently killing all future scheduled runs of the sync task. Replace with IDEA Logger warnings so failures are visible in the IDE log. Add explicit connect/read timeouts (5s) to prevent a hung server from blocking the shared executor indefinitely. Early-return when the remote config URL is not configured so no work is done at all. Remove redundant addRemoteSyncJob() call from settings reset(), which only restores UI fields and should not restart the sync. Ref: #8606 (comment)
Contributor
|
No documentation updates needed for this PR. This is an internal bug fix that hardens the JetBrains remote config sync implementation to prevent IDE freezes. The changes (adding timeouts, improving error handling, code cleanup) don't affect any user-facing behavior or APIs. The remote config sync feature continues to work the same way from a user's perspective—it just operates more reliably now. Additionally, the |
Patrick-Erichsen
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
service<ContinueSentryService>().report(...)from the remote config sync catch block — this call could itself throw from the background executor thread, letting the original exception escape and silently killing all future scheduled sync runs (aScheduledFuturestops rescheduling when the runnable throws)Logger.warn()so sync failures are visible in the IDEA logconnectTimeout(5000)/readTimeout(5000)to prevent a hung remote server from blocking the sharedAppScheduledExecutorServiceindefinitelysyncRemoteConfig()andaddRemoteSyncJob()whenremoteConfigServerUrlis not configured, so no work is done at all for users who don't use this deprecated settingaddRemoteSyncJob()call fromreset(), which only restores UI fields from saved stateRef: #8606 (comment)
Test plan
remoteConfigServerUrlis not set (default)Summary by cubic
Prevents IDE freezes by hardening the JetBrains remote config sync. Failures now log without killing future runs, and hung servers no longer block the shared executor.
service<ContinueSentryService>().report(...)withLogger.warn()so exceptions don’t escape the scheduler thread.connectTimeout(5000)andreadTimeout(5000)toHttpRequeststo avoid blockingAppScheduledExecutorService.remoteConfigServerUrlis empty in bothsyncRemoteConfig()andaddRemoteSyncJob().remoteSyncFuturebefore scheduling; removed redundantaddRemoteSyncJob()fromreset().Written for commit 4a85441. Summary will update on new commits.