Skip to content

Fix netteConnector with phpunit10 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Fix netteConnector with phpunit10 #41

merged 1 commit into from
Mar 9, 2023

Conversation

jakubvojacek
Copy link
Contributor

Because of https://github.com/sebastianbergmann/phpunit/blob/main/src/TextUI/Configuration/Merger.php#L102, phpunit relies on $_SERVER['PHP_SELF']. It works fine when there's just one suite. But when there are more, the 2nd suite would fail on the line above because $_SERVER['PHP_SELF'] would be null and realpath() does not accept null.

Perhaps there is a "nicer" solution but this PR fixes the issue I was having completely.

If merged, please tag a new release if at all possible.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4351254014

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 54.857%

Totals Coverage Status
Change from base Build 4269784254: 0.5%
Covered Lines: 96
Relevant Lines: 175

💛 - Coveralls

@f3l1x f3l1x merged commit 1db5777 into contributte:master Mar 9, 2023
@jakubvojacek
Copy link
Contributor Author

possible to tag a release please @f3l1x ?

@f3l1x
Copy link
Member

f3l1x commented Mar 9, 2023

Sure, pls don't rush. :-)

https://github.com/contributte/codeception/releases/tag/v1.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants