fix: made lerna a peerDependency to avoid installing it multiple times #371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
lerna@^2.9.0
should be apeerDependency
(and for the purposes of the tests adevDependency
) instead of adependency
.Motivation and Context
This will avoid situations in which multiple versions of
lerna
get installed into a monorepo and it barfs when you try to run one of the commands (with "Incompatible local version of lerna detected!") due to yourlerna.json#version
not matching the version which has decided to run. (This sometimes happens ifyarn
has decided to install your packages into a slightly weird folder structure and the version oflerna
which is being picked up is not the version that you installed within your rootpackage.json
.)Usage examples
N/A
How Has This Been Tested?
I ran
yarn test
at the root of the monorepo.Types of changes
Checklist: