Upgrade actions/checkout and actions/upload-artifact to v7 - #1371
Merged
Conversation
and `archive: false` to prevent nested archives
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe workflow consolidates Windows, Linux, SteamOS, macOS ARM, and macOS Intel builds into one matrix-based job. Matrix values configure runners, dependencies, build commands, executable paths, and archive contents. Shared steps perform checkout, building, hashing, zipping, and artifact upload. SteamOS retains 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/build-coop.yaml:
- Around line 38-42: Update the upload-artifact steps in the build workflow to
preserve the configured platform artifact names: either rename each ZIP to the
corresponding configured name before upload or keep archive enabled so the name
field is honored. Apply this consistently to the Linux, SteamOS, Windows, macOS
ARM, and macOS Intel artifact uploads, and retain compatibility with existing
artifact consumers.
- Line 16: Update every actions/checkout step in the build workflow, including
the steps near lines 16, 49, 85, 128, and 184, to explicitly set
persist-credentials to false while preserving the existing checkout
configuration.
- Line 16: Add workflow-level least-privilege permissions in the build-coop
workflow by declaring contents: read for the default GITHUB_TOKEN scope. Review
each job for artifact uploads and grant only the additional uploader permission
required at that job level, without broadening unrelated permissions.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: dd183b12-2aa8-4019-8298-a9cc743f5171
📒 Files selected for processing (1)
.github/workflows/build-coop.yaml
Collaborator
|
We shall see when the action run finishes, but there's a chance you'll need to not set archiving to false on macOS. |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/build-coop.yaml:
- Around line 48-52: Update the build-coop workflow to consistently use the
defined matrix.platform key instead of matrix.plat across the job’s name,
runner, shell, steps, and conditions. Ensure defaults.run.shell has an explicit
valid fallback such as bash for non-Windows platform entries while preserving
the Windows shell selection.
- Around line 22-27: Split the combined [Linux, SteamOS] matrix entry into
separate Linux and SteamOS entries in the build matrix, giving each a scalar
name while preserving their shared os, deps, and zip values. Ensure the existing
matrix.plat.name-based job naming, ZIP naming, and HANDHELD condition receive
the correct platform name.
- Around line 44-47: Remove the invalid include block from the matrix
configuration in the build workflow and assign the make command directly to
every existing platform entry. Ensure each platform retains its required os and
zip values, and remove the trailing whitespace.
- Line 81: Update the build command in the workflow matrix run step to remove
the unsupported case() expression. Add HANDHELD=1 directly to the SteamOS make
value or replace it with a GitHub Actions-supported conditional expression,
while preserving the existing command for other platforms.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: fca4d4db-5f89-473d-866b-aad4a65abbe2
📒 Files selected for processing (1)
.github/workflows/build-coop.yaml
Contributor
Author
|
@coderabbitai resume |
✅ Action performedReviews resumed. |
Squishy6094
approved these changes
Aug 7, 2026
Squishy6094
left a comment
Squishy6094
left a comment
Contributor
There was a problem hiding this comment.
Workflow looks really clean!
PeachyPeachSM64
approved these changes
Aug 13, 2026
EmeraldLoc
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also allows to use the
archive: falseinput forupload-artifactto prevent nested archives