-
-
Notifications
You must be signed in to change notification settings - Fork 304
fix: regenerate variables map to allow selection on all supported collections #1371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1371 +/- ##
==========================================
+ Coverage 83.84% 84.36% +0.51%
==========================================
Files 170 170
Lines 9909 9925 +16
==========================================
+ Hits 8308 8373 +65
+ Misses 1357 1308 -49
Partials 244 244
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f260e1e to
9b2f10f
Compare
481c118 to
e667f84
Compare
M4tteoP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I had to rebase to fix a conflict
This is a follow-up on #1143.
I somehow managed to not commit the latest version of the auto-generated
internal/variables/variablesmap.gen.gofile, which broke some rules (for example,SecRule FILES:foo ...is currently refused but should work).This PR:
go generateand return an error if there's any changes