Skip to content

fix: update constants for recursion limit #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fzipi merged 2 commits into from
Mar 6, 2026
Merged

fix: update constants for recursion limit #1512

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a6cd42
fix: conflate the constants for recursion limit
jcchavezs Mar 6, 2026
3cc4dfa
fix: value setting
jcchavezs Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions internal/bodyprocessors/json.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ import (
"github.com/corazawaf/coraza/v3/experimental/plugins/plugintypes"
)

// responseBodyRecursionLimit is the default recursion depth limit for response body JSON parsing.
// Uses the same default as request bodies (1024) to protect against deeply nested structures.
const responseBodyRecursionLimit = 1024

type jsonBodyProcessor struct{}

var _ plugintypes.BodyProcessor = &jsonBodyProcessor{}
Expand Down Expand Up @@ -52,7 +48,7 @@ func (js *jsonBodyProcessor) ProcessRequest(reader io.Reader, v plugintypes.Tran
return nil
}

func (js *jsonBodyProcessor) ProcessResponse(reader io.Reader, v plugintypes.TransactionVariables, _ plugintypes.BodyProcessorOptions) error {
func (js *jsonBodyProcessor) ProcessResponse(reader io.Reader, v plugintypes.TransactionVariables, bpo plugintypes.BodyProcessorOptions) error {
// Read the entire body to store it and process it
s := strings.Builder{}
if _, err := io.Copy(&s, reader); err != nil {
Expand All @@ -62,7 +58,7 @@ func (js *jsonBodyProcessor) ProcessResponse(reader io.Reader, v plugintypes.Tra

// Process with recursion limit
col := v.ResponseArgs()
data, err := readJSON(ss, responseBodyRecursionLimit)
data, err := readJSON(ss, bpo.RequestBodyRecursionLimit)
if err != nil {
return err
}
Expand Down
2 changes: 1 addition & 1 deletion internal/corazawaf/transaction.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ type Transaction struct {
HashEnforcement bool

// Stores the last phase that was evaluated
// Used by allow to skip phasesx
// Used by allow to skip phases
lastPhase types.RulePhase

// Handles request body buffers
Expand Down
Loading