Skip to content

fix: correct two compile errors in SecUploadKeepFiles implementation #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fzipi merged 2 commits into from
Mar 17, 2026
Merged

fix: correct two compile errors in SecUploadKeepFiles implementation #1560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e2a8f0
Initial plan
Copilot Mar 17, 2026
468f7e9
fix: correct lint errors - HasAccessToFS is a bool not a function, fi…
Copilot Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/corazawaf/waf.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ func (w *WAF) Validate() error {
return errors.New("request body json depth limit should be bigger than 0")
}

if environment.HasAccessToFS() {
if environment.HasAccessToFS {
if w.UploadKeepFiles != types.UploadKeepFilesOff && w.UploadDir == "" {
return errors.New("SecUploadDir is required when SecUploadKeepFiles is enabled")
}
Expand Down
2 changes: 1 addition & 1 deletion internal/seclang/directives.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -959,7 +959,7 @@ func directiveSecUploadKeepFiles(options *DirectiveOptions) error {
return err
}

if !environment.HasAccessToFS && status != types.UploadKeepFilesStatusOff {
if !environment.HasAccessToFS && status != types.UploadKeepFilesOff {
return fmt.Errorf("SecUploadKeepFiles: cannot enable keeping uploaded files: filesystem access is disabled")
}

Expand Down
Loading