Skip to content

RN Keep Awake is not compatible with React Native 0.56 (Android) #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
taranda opened this issue Jul 6, 2018 · 12 comments
Closed

RN Keep Awake is not compatible with React Native 0.56 (Android) #48

taranda opened this issue Jul 6, 2018 · 12 comments

Comments

@taranda
Copy link

taranda commented Jul 6, 2018

This package will not compile with React Native 0.56. Due to Google's mandate to target SDK 26 by 1 August 2018, React Native upgraded their target SDK. This is change in not compatible with react-native-keep-awake.

New apps will not be able to submit to the Google Play store as of 1 August 2018 unless they use React Natvie 0.56, so a fix to this issue is time sensitive.

Replication:

  1. Create a new react native app using react-native init
  2. Install react-native-keep-awake by following the instructions in this repo.
  3. Run the app on an android device by executing react-native run-android.
  4. This is the error message:
A problem occurred configuring project ':react-native-keep-awake'.
      > The SDK Build Tools revision (23.0.1) is too low for project ':react-native-keep-awake'. Minimum required is 25.0.0

package.json:

"dependencies": {
    "react": "16.4.1",
    "react-native": "0.56.0",
    "react-native-keep-awake": "^3.0.1"
  },
@taranda taranda changed the title RN Keep Awake not compatible with React Native 0.56 (Android) RN Keep Awake is not compatible with React Native 0.56 (Android) Jul 6, 2018
@patriciob00
Copy link

I had the same trouble, the lib is not compatible with my project version of RN, does someone knows one alternative?

@abartolo
Copy link

@corbt I am not too familiar with the task to upgrade the project to SDK 26, any idea if this would be a big lift?

@taranda
Copy link
Author

taranda commented Jul 12, 2018

Here are a few solutions proposed in other packages:

CptFabulouso added a commit to CptFabulouso/react-native-keep-awake that referenced this issue Jul 12, 2018
update gradle

people might need to upgrade gradle to new version also in their projects
@corbt
Copy link
Owner

corbt commented Jul 12, 2018

Could any of the users in this thread try out #49 and confirm whether the fix works? If that works I'm happy to merge and release a new version!

@arpitjacob
Copy link

@corbt YES Works great, thanks 👍

@taranda
Copy link
Author

taranda commented Jul 13, 2018

PR #49 did not work for me. I submitted comments to PR #49 with recommended changes.

@abartolo
Copy link

@corbt Updated code locally to reflect merge request and everything worked!

@taranda Nice work!

@taranda
Copy link
Author

taranda commented Jul 14, 2018

@abartolo Thanks.

@corbt I recommend merging PR #49.

@corbt
Copy link
Owner

corbt commented Jul 22, 2018

Should be fixed in 3.1.0 -- thanks!

@arpitjacob
Copy link

@corbt you mean 3.0.1

@corbt
Copy link
Owner

corbt commented Jul 23, 2018

@ThaJay
Copy link

ThaJay commented Sep 19, 2018

Xcode does warn that this still compiles for iOS 7 while react-native compiles for iOS 9 since 0.56.0 but it seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants