libpriv/kernel: Pass through DRACUT_NO_XATTR when running dracut#5397
Merged
cgwalters merged 1 commit intocoreos:mainfrom May 26, 2025
Merged
libpriv/kernel: Pass through DRACUT_NO_XATTR when running dracut#5397cgwalters merged 1 commit intocoreos:mainfrom
DRACUT_NO_XATTR when running dracut#5397cgwalters merged 1 commit intocoreos:mainfrom
Conversation
Since f4aecb9 ("rust/bwrap: don't swallow STDERR when running commands"), we now have the stderr from dracut, which reveals that it spews lots of warnings about being unable to copy xattrs when running from an `rpm-ostree compose rootfs`. I think this comes from the `user.ostreemeta` xattr which hasn't been stripped yet. It'd be better anyway to do this stripping within the rpm-ostree core I think, but for now it's actually trivial to work around this by setting `DRACUT_NO_XATTR`. I'm pretty sure we could set this unconditionally, but out of an abundance of caution, we only do this for now from the `rpm-ostree compose rootfs` path where we know we want this. Fixes: https://gitlab.com/fedora/bootc/tracker/-/issues/66
Member
Author
|
/test fcos-e2e |
|
@jlebon: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
cgwalters
approved these changes
May 26, 2025
| = g_strdup_printf ("#!/usr/bin/bash\n" | ||
| "set -euo pipefail\n" | ||
| "export PATH=%s:${PATH}\n" | ||
| "export PATH=%s:${PATH} %s%s\n" |
Member
There was a problem hiding this comment.
This isn't new but I think it'd be perhaps conceptually cleaner to use bwrap --setenv below?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since f4aecb9 ("rust/bwrap: don't swallow STDERR when running commands"), we now have the stderr from dracut, which reveals that it spews lots of warnings about being unable to copy xattrs when running from an
rpm-ostree compose rootfs.I think this comes from the
user.ostreemetaxattr which hasn't been stripped yet.It'd be better anyway to do this stripping within the rpm-ostree core I think, but for now it's actually trivial to work around this by setting
DRACUT_NO_XATTR.I'm pretty sure we could set this unconditionally, but out of an abundance of caution, we only do this for now from the
rpm-ostree compose rootfspath where we know we want this.Fixes: https://gitlab.com/fedora/bootc/tracker/-/issues/66