treefile: merge 'repo-metadata' config

[champtar]

This change allow to set the 'repo-metadata' option into the base manifest file instead of being forced to set it into the leaf manifest file (the one with the last include).

We now serialize 'repo-metadata: inline', causing an input hash change for people explicitely setting the default.

[openshift-ci]

Hi @champtar. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[gemini-code-assist]

Code Review

This pull request refactors the repo-metadata configuration option to allow it to be merged from included treefiles. This is achieved by changing its type from a raw enum to an Option<enum>, which correctly models its optional nature and allows the existing merge logic to apply. The changes are well-implemented, including necessary updates to accessor functions and cleanups of related code. The documentation has also been updated to reflect the correct kebab-casing for the option name. A side effect of this change is that explicitly setting the default value for repo-metadata will now affect the input hash, which is a reasonable and more correct behavior. Overall, the changes are solid and improve the configuration flexibility.

[cgwalters]

Guessing here: Are you disabling the repo metadata (for reproducibility reasons?)

[champtar]

Guessing here: Are you disabling the repo metadata (for reproducibility reasons?)

Yes, I'm aiming for 100% reproducible ostree commits and containers

[cgwalters]

Yes, I'm aiming for 100% reproducible ostree commits and containers

Makes sense. That's the kind of thing that I find really useful in commit messages. I wasn't going to block on it but basically just a single sentence like:

This way it's easy for me to disable the repo metadata so I can more easily get reproducible builds.

Is so useful for people in the future.

[champtar]

I wasn't going to block on it

I don't mind, don't hesitate next time