Skip to content

treefile,compose: add advisories-metadata option#5474

Merged
cgwalters merged 1 commit intocoreos:mainfrom
champtar:advisories-metadata
Sep 2, 2025
Merged

treefile,compose: add advisories-metadata option#5474
cgwalters merged 1 commit intocoreos:mainfrom
champtar:advisories-metadata

Conversation

@champtar
Copy link
Contributor

Similar to repo-metadata, advisories-metadata option allow to set
if you should store advisories information in the commit metadata,
in the detached metadata, or not at all.

@openshift-ci
Copy link

openshift-ci bot commented Aug 25, 2025

Hi @champtar. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

runcompose
echo "ok compose detached"

ostree --repo=${repo} show --print-metadata-key rpmostree.advisories ${treeref} && \

Check warning

Code scanning / shellcheck

repo is referenced but not assigned. Warning test

repo is referenced but not assigned.
runcompose
echo "ok compose detached"

ostree --repo=${repo} show --print-metadata-key rpmostree.advisories ${treeref} && \

Check warning

Code scanning / shellcheck

treeref is referenced but not assigned. Warning test

treeref is referenced but not assigned.
@champtar champtar force-pushed the advisories-metadata branch 2 times, most recently from b9061b7 to e32a287 Compare August 25, 2025 20:44
Similar to repo-metadata, advisories-metadata option allow to set
if you should store advisories information in the commit metadata,
in the detached metadata, or not at all.

This help with reproducibility has advisories might evolve separetely
from the packages, and depending on how you create your mirrors
advisories might be missing.
@champtar champtar force-pushed the advisories-metadata branch from e32a287 to c8da95c Compare August 27, 2025 13:50
@champtar champtar marked this pull request as ready for review August 27, 2025 13:52
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cgwalters
Copy link
Member

/override ci/prow/fcos-e2e

@openshift-ci
Copy link

openshift-ci bot commented Sep 2, 2025

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/fcos-e2e

Details

In response to this:

/override ci/prow/fcos-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cgwalters cgwalters enabled auto-merge September 2, 2025 22:32
@cgwalters cgwalters merged commit 8639c08 into coreos:main Sep 2, 2025
17 of 18 checks passed
@champtar champtar deleted the advisories-metadata branch September 2, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants