Conversation
There was a problem hiding this comment.
Code Review
This pull request prepares for the 2025.11 release. The changes primarily consist of version number increments in configure.ac and packaging/rpm-ostree.spec. The updates are consistent and align with the release procedures documented in RELEASE.md. I have one suggestion to improve the release process's maintainability by centralizing the version number definition, which is currently specified in two separate files. This would help prevent potential inconsistencies in future releases.
| dnl | ||
| m4_define([year_version], [2025]) | ||
| m4_define([release_version], [10]) | ||
| m4_define([release_version], [11]) |
There was a problem hiding this comment.
The version number is defined here and also in packaging/rpm-ostree.spec. Having the version number in multiple places increases the chance of them becoming inconsistent during future releases. To improve maintainability, consider defining the version in a single source of truth (e.g., a dedicated VERSION file) and have both this file and the spec file read from it. This would simplify the release process and make it less error-prone.
| Summary: Hybrid image/package system | ||
| Name: rpm-ostree | ||
| Version: 2025.10 | ||
| Version: 2025.11 |
There was a problem hiding this comment.
The version number is defined here and also in configure.ac. To improve maintainability and avoid potential inconsistencies in future releases, consider defining the version in a single source of truth (e.g., a dedicated VERSION file) and have both this spec file and configure.ac read from it. This would simplify the release process and make it less error-prone.
|
@jmarrero: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/override continuous-integration/jenkins/pr-merge |
|
@cgwalters: Overrode contexts on behalf of cgwalters: continuous-integration/jenkins/pr-merge DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Release 2025.11