Skip to content

fix(CToast): change special prop key to innerKey #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 18, 2024
Merged

fix(CToast): change special prop key to innerKey #405

merged 3 commits into from
Sep 18, 2024

Conversation

jasperfirecai2
Copy link
Contributor

see related issue #404
this resolves the warning by allowing a passed key instead of using a reserved keyword

@mrholek
Copy link
Member

mrholek commented Sep 18, 2024

@jasperfirecai2 thank you for this PR, but before merging, the key must also be updated in CToaster.tsx

@jasperfirecai2
Copy link
Contributor Author

jasperfirecai2 commented Sep 18, 2024 •
edited
Loading

Thanks for the reply, would that be the key in the addToast method? also, i cant seem to be able to cleanly rebase

@mrholek mrholek changed the title fix special key prop in CToast fix(CToast): change special prop key to innerKey Sep 18, 2024
@mrholek mrholek merged commit 57dcda2 into coreui:main Sep 18, 2024
@jasperfirecai2 jasperfirecai2 mentioned this pull request Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasperfirecai2 @mrholek