Issue converting #define pointers to checked types

[hasantouma]

I came across this issue when converting the icecast code.

The issue can be illustrated with this small example:

#ifndef foo
#define foo int
#endif

int main() {
  foo* a;

  return 0;
}

checked-c-convert produces this:

#ifndef foo
#define foo int
#endif

int main() {
  _Ptr<int>  aa;

  return 0;
}

Note the variable name change and the _Ptr<> change from foo to int

[hasantouma]

This is a more extensive example of the issue:

C code:

#ifndef foo
#define foo int
#endif

int main() {
  foo *a, *b, *c;

  return 0;
}

checked-c-convert output:

#ifndef foo
#define foo int
#endif

int main() {
  foo *a, *b, *c_Ptr<int> a;
_Ptr<int> b;
_Ptr<int> c;
;

  return 0;
}

[hasantouma]

This is another example of the macro expansion issue. clang performs all the preprocessing expansions before it gets to the AST that we process. So the tool ends up rewriting globally defined macros. This can cause readability issues down the line with bigger projects and more complex macros.

This issues happens when multiple declarations are on the same line. i.e.:
char *version=NULL, *resp_code=NULL, *message=NULL;

In Icecast:
file: src/http/http.c
function: httpp_parse_response()
local variables version, resp_code, and message were originally initialized to NULL but the tool converted them to ((void *)0)

This small example demonstrates the issue:
foo.c:

#include <stdlib_checked.h>

int main() {

  char *p = NULL, *q = NULL;

  return 0;
}

checked-c-convert output (baz.checked.c):

#include <stdlib_checked.h>

int main() {

 _Ptr<char> p = ((void *)0);
_Ptr<char> q = ((void *)0);


  return 0;
}

[mwhicks1]

All of these still seem to be issues.

[john-h-kastner]

The first example is fixed by #254, but the other are still unresolved.

[kyleheadley]

These examples now pass as described.