Rewriting error on inline structure definition

[john-h-kastner]

An assertion fail while rewriting this with-alltypes. It looks like this happen when we try to rewrite a source range where the start SourceLocation comes after the end SourceLocation.

void a() {
  struct {int i;} *b;
}

3c:  clang/lib/Rewrite/RewriteRope.cpp:380: void {anonymous}::RopePieceBTreeLeaf::erase(unsigned int, unsigned int): Assertion `getPiece(StartPiece).size() > NumBytes' failed.

This error causes the -alltypes conversion of libarchive to fail.

[john-h-kastner]

As a starting point, if the struct is a global declaration, then the conversion is just fine. I know the AST is different for top level global declarations and local variable declarations, so the error is probably coming from this difference.

struct {int i;} *b;

[john-h-kastner]

global decl

struct {int i;} *b;

TranslationUnitDecl 0x5589a7ac9798 <<invalid sloc>> <invalid sloc>
|-<builtin-junk>
......
|-RecordDecl 0x5589a7b09448 <c.c:1:1, col:15> col:1 struct definition
| `-FieldDecl 0x5589a7b09550 <col:9, col:13> col:13 i 'int'
`-VarDecl 0x5589a7b09690 <col:1, col:18> col:18 b 'struct (anonymous struct at c.c:1:1) *'

local decl

void foo() {
  struct {int i;} *b;
}

TranslationUnitDecl 0x55797268a798 <<invalid sloc>> <invalid sloc>
|-<builtin-junk>
......
`-FunctionDecl 0x5579726ca4b0 <c.c:1:1, line:3:1> line:1:6 foo 'void ()'
  `-CompoundStmt 0x5579726ca8a8 <col:12, line:3:1>
    `-DeclStmt 0x5579726ca890 <line:2:1, col:19>
      |-RecordDecl 0x5579726ca5b0 <col:1, col:15> col:1 struct definition
      | `-FieldDecl 0x5579726ca6c0 <col:9, col:13> col:13 i 'int'
      `-VarDecl 0x5579726ca800 <col:1, col:18> col:18 b 'struct (anonymous struct at c.c:2:1) *'