Skip to content

_Assume_bounds_cast added with checked array type #728

Open
@kyleheadley

Description

@kyleheadley

The icecast benchmarks includes a few copies of this error:

md5.c:122:112: error: expected _Array_ptr type
          MD5Transform(_Assume_bounds_cast<uint32_t _Checked[4]>(ctx->buf, ...),...);
                                           ^

According to the spec, _Assume_bounds_cast must use a checked pointer type (_Ptr,_Array_ptr, or _Nt_array_ptr).

In this case, both MD5Transform and ctx->buf use identical uint32_t buf[4] types in the source. I assume ctx could not be verified, hence the cast.

We probably need a new code path for sized arrays, if it doesn't already exist.

Metadata

Metadata

Assignees

No one assigned

    Labels

    benchmark failureA bug causing a failure in our nightly benchmark testscast

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions