Skip to content

Fix for issue 182/183 - The Sequel #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Fix for issue 182/183 - The Sequel #189

merged 1 commit into from
Jul 22, 2020

Conversation

sroy4899
Copy link

Changed rewriting so that we only insert void for nullary functions when their return types are pointer types.
Closes #182
Closes #183

@@ -1,4 +1,4 @@
// RUN: cconv-standalone %s | FileCheck -match-full-lines %s
// RUN: cconv-standalone %s | count 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's going on with this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means no conversion should happen. Since there’s not output, the only thing to “check” is that the number of converted lines is 0.

Copy link
Member

@mwhicks1 mwhicks1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't understand the last test, but otherwise looks good. Merge when ready.

@mwhicks1 mwhicks1 merged commit 2f1ab7c into BigRefactor Jul 22, 2020
@mwhicks1 mwhicks1 deleted the iss182-3 branch July 22, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants