293 convert partial #304
Merged
293 convert partial #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of considering a pointer "originally checked" if any one of the pointer levels in it is checked in the source, characterize each pointer level individually.
mwhicks1
reviewed
Oct 26, 2020
mwhicks1
reviewed
Oct 26, 2020
mwhicks1
reviewed
Oct 26, 2020
mwhicks1
reviewed
Oct 28, 2020
| @@ -404,10 +404,10 @@ class FunctionVariableConstraint : public ConstraintVariable { | |||
| FunctionVariableConstraint(FunctionVariableConstraint *Ot, | |||
| Constraints &CS); | |||
| // N constraints on the return value of the function. | |||
| ConstraintVariable *ReturnVar; | |||
| PVConstraint *ReturnVar; | |||
There was a problem hiding this comment.
Nice. I recall thinking in the past that this was always true and we should refactor.
mwhicks1
reviewed
Oct 28, 2020
| @@ -377,7 +377,7 @@ class PointerVariableConstraint : public ConstraintVariable { | |||
| // Get the set of constraint variables corresponding to the arguments. | |||
| const std::set<ConstraintVariable *> &getArgumentConstraints() const; | |||
|
|
|||
| ConstraintVariable *getCopy(Constraints &CS) override; | |||
| PointerVariableConstraint *getCopy(Constraints &CS) override; | |||
There was a problem hiding this comment.
So in C++ you can override a method whose return type is T with a method whose return type is S <: T ?
There was a problem hiding this comment.
I wasn't sure of this myself, but it does seem to be the case. The override annotation will trigger an error if try you an invalid override but, it doesn't complain here.
mwhicks1
reviewed
Oct 28, 2020
| std::string Rsn = | ||
| "Unchecked pointer in parameter or return of external function " + | ||
| FuncName; | ||
| if (!G->getReturnVar()->getIsGeneric()) |
There was a problem hiding this comment.
Why this exception? I guess if it's generic, we are assuming the underlying pointer, even if void *, should not be constrained to WILD?
mwhicks1
approved these changes
Oct 28, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change
3Cis able to convert partially checked pointer types into fully checked pointer types.e.g.,
can be converted to
provided that
ais used safely.More examples are in the test case
partial_checked.c.A large number of test cases are modified as a side effect of this change. When converting the converted output from
3Ca second time to check for idempotence , we had to usediffto check that no changes occurred in some cases.3Cwill now not generate a converted output file in some of these cases.