Skip to content

Remove obsolete tests that were incorrectly resurrected #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2020

Conversation

mattmccutchen-cci
Copy link
Member

(During the merge in 4c4eed3.)

complex_expressionBUG was renamed back to complex_expression in
782449d, and the merge incorrectly kept
both copies. The other 5 tests were deleted in
03f86af.

One other test (lowerboundBUG) was incorrectly resurrected during that
merge after it was deleted in 0398f04,
but it was later deleted again in
addfe37.

merge in 4c4eed3.

complex_expressionBUG was renamed back to complex_expression in
782449d, and the merge incorrectly kept
both copies.  The other 5 tests were deleted in
03f86af.

One other test (lowerboundBUG) was incorrectly resurrected during that
merge after it was deleted in 0398f04,
but it was later deleted again in
addfe37.
Copy link

@sroy4899 sroy4899 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inlinestruct test deletion looks good and makes sense to me. I can't speak on the complex_expression test, because I didn't write it, but if you're OK with that, then this looks ready to merge to me. :)

@mattmccutchen-cci mattmccutchen-cci merged commit 679d3b5 into main Dec 30, 2020
@mattmccutchen-cci mattmccutchen-cci deleted the remove-mismerged-tests branch December 30, 2020 19:16
mattmccutchen-cci added a commit that referenced this pull request Feb 5, 2021
All 6 tests deleted in #364 except for complex_expressionBUG were in
test_updater.
mattmccutchen-cci added a commit that referenced this pull request Feb 10, 2021
All 6 tests deleted in #364 except for complex_expressionBUG were in
test_updater.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants