Refactor to include generic types info in VCs #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwhicks1
approved these changes
Jan 11, 2021
| auto *ParamVar = new PVConstraint(QT, ParmVD, PName, I, Ctx, &N); | ||
| int GenericIdx = ParamVar->getGenericIndex(); | ||
| if (GenericIdx >= 0) | ||
| TypeParams = std::max(TypeParams, GenericIdx + 1); |
There was a problem hiding this comment.
I don't understand this update to TypeParams
There was a problem hiding this comment.
TypeParams represents the number of variables in Itype_for_any(...) for a function. Unfortunately, I was unable to read this information directly from the decl. But, each parameter and return var has an index attached, so the max index (+1) is the number of variables. Eventually the rewriter will need to know the location of that phrase in the code, so if you're aware of it let me know. I could make this code slightly more efficient or save the notes for later.
There was a problem hiding this comment.
Makes sense. Changes all look good to me then.
mwhicks1
approved these changes
Jan 12, 2021
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the generic flag to an index, and have other functions rely on this index rather than regenerating it from decl itypes. This is in preparation for changing these indexes in TypeVariableAnalysis later, so that we can i.e. change
void *toT *.All other functionality remains unchanged. Regression tests are unaffected.