CheckedRegionFinder: "void" does not contain an unchecked pointer. #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmccutchen-cci
force-pushed
the
checked-region-void-return
branch
from
c0fb8f4 to
62a4f4f
Compare
|
I think this is good. Thanks for the catch. |
aaronjeline
approved these changes
Feb 15, 2021
mattmccutchen-cci
added a commit
that referenced
this pull request
Mar 10, 2021
The changes look harmless aside from whitespace, which will be redone soon anyway. The addition of checked regions is presumably due to #426. (testgenerator.py and processor.py already had no diffs.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this apparent bug while trying to write a regression test for #423. Is this seemingly obvious fix correct, or should I file an issue for further discussion? Do we need a dedicated regression test, or can we rely on the existing tests that expected the buggy behavior and that I'm updating to expect the corrected behavior?
Aaron: I'm tentatively requesting review from you since I see you've done some work on checked regions. If you're not familiar enough with the topic to be confident about this change, we can ask John.