Remove special handling of functions defined in system headers. #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The liberal itypes change (#356) added code to flag them as not having a body even though they did. This may have been a useful mitigation for certain problems with unwritable files at the time, but it risks causing confusion and violating 3C invariants in the future. From now on, we want to handle all unwritable files (including system headers) via the new canWrite constraints approach. It appears that removing this code will immediately fix one problem with cast insertion that is currently blocking the benchmark tests (#423), so we'll go ahead and make this change even though we don't fully understand the cast insertion problem or how to appropriately regression-test it.
john-h-kastner
approved these changes
Feb 16, 2021
There was a problem hiding this comment.
This looks good. It fixes that benchmarks test that I expected it to.
The problem that the isInSysytemHeader checked fixed was that atoi instdlib.h was not constrained to WILD because it had a body, and we were not doing correct base dir checks. With the base dir fix, this change should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The liberal itypes change (#356) added code to flag them as not having a
body even though they did. This may have been a useful mitigation for
certain problems with unwritable files at the time, but it risks causing
confusion and violating 3C invariants in the future. From now on, we
want to handle all unwritable files (including system headers) via the
new canWrite constraints approach.
It appears that removing this code will immediately fix one problem with
cast insertion that is currently blocking the benchmark tests (#423), so
we'll go ahead and make this change even though we don't fully
understand the cast insertion problem or how to appropriately
regression-test it.