Fix incorrect rewritting of function with typdefed type #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a error in rewriting for function declaration such as
typedef void foo(int*);
foo bar;
void bar(int *a){};
Previously `FunctionDeclBuilder` only replaced the parameter declaration
of `bar` because nothing in the return type needed to be rewritten. This
caused the rewriting of the first declaration to be missing the return
type. With this change, `FunctionDeclBuilder` detects that `bar` is
declared using a typedef type, and generates replacement text for the
entire declaration instead of only the parameter list.
mwhicks1
approved these changes
Feb 18, 2021
There was a problem hiding this comment.
LGTM. Is there a place in the code where you can put a comment about not generating the constraint variables properly, due to typedefs used for function types? Filing the issue #437 is good, but if you have a guess about where in the code it matters, you could note that.
john-h-kastner
force-pushed
the
fix_430
branch
from
a655b68 to
abe0e17
Compare
due to a macro. Cleanup: It doesn't seem like we need the special case for typedefs in tyToStr. Indeed, if the type is actually a TypedefType, I'd expect Clang to print it as such.
Co-authored-by: Matt McCutchen (Correct Computation) <[email protected]>
john-h-kastner
force-pushed
the
fix_430
branch
from
359eb53 to
05bda18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #430 , an error in rewriting for function declaration such as
Previously
FunctionDeclBuilderonly replaced the parameter declarationof
barbecause nothing in the return type needed to be rewritten. Thiscaused the rewriting of the first declaration to be missing the return
type. With this change,
FunctionDeclBuilderdetects thatbarisdeclared using a typedef type, and generates replacement text for the
entire declaration instead of only the parameter list.
Note that this PR does not implement proper constraint generation for these functions, it only improves the rewriting logic to avoid assertion fails or generating invalid code.