Skip to content

Remove conditional stopping creating of constraint variables #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2021

Conversation

john-h-kastner
Copy link
Collaborator

This fixes #297 which is blocking libarchive. It's a simple fix, but I'm a little hesitant to remove the if (FE && FE->isValid()) conditional without understanding why it was there in the first place.

@mattmccutchen-cci
Copy link
Member

mattmccutchen-cci commented Feb 23, 2021

I guess the condition must be false in the example of #297 in order for your change to make a difference? Can you print out some more information (or attach the debugger) and find out more about the significance of it being false (the file entry not being valid) in this case? (Maybe I'm stating the obvious...)

Duh, I read #297 now. The condition is false because the struct c is inside a macro. So your question is why we thought it was unsafe to add a constraint variable when the struct c is inside a macro. I don't know, but in general, we don't have a good way to control for bugs that don't show up in any of our tests, so I'd say go for it.

@john-h-kastner john-h-kastner merged commit 84a263d into main Feb 26, 2021
@john-h-kastner john-h-kastner deleted the fix_297 branch March 9, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fields not added to variables map when struct identifier is in macro
2 participants