Skip to content

Add check-3c target with fewer dependencies than check-clang-3c. #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

mattmccutchen-cci
Copy link
Member

This may significantly speed up the build.

(As I've mentioned elsewhere, I believe many of the removed steps are link steps that are especially slow on Windows. Indeed, my recent Windows builds of check-3c have been much faster than my previous builds of check-clang-3c. However, I haven't taken the time to perform a direct comparison to rule out other explanations for the difference, so I'm not making a more definite statement about the build time in the files.)

I'll make the corresponding documentation update in this repository separately, presumably as part of #438.

This may significantly speed up the build.
Copy link
Collaborator

@john-h-kastner john-h-kastner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. I'm not too familiar with cmake, but nothing looks wrong.

@mattmccutchen-cci mattmccutchen-cci merged commit abe6923 into main Feb 26, 2021
@mattmccutchen-cci mattmccutchen-cci deleted the check-3c branch February 26, 2021 18:39
mattmccutchen-cci added a commit that referenced this pull request Mar 23, 2021
…456)

This may significantly speed up the build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants