3C code style pass 2021-02 #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwhicks1
reviewed
Mar 1, 2021
mwhicks1
reviewed
Mar 1, 2021
mwhicks1
reviewed
Mar 1, 2021
mwhicks1
reviewed
Mar 1, 2021
mwhicks1
reviewed
Mar 1, 2021
mwhicks1
reviewed
Mar 1, 2021
mwhicks1
reviewed
Mar 1, 2021
mwhicks1
reviewed
Mar 1, 2021
mwhicks1
reviewed
Mar 1, 2021
mwhicks1
reviewed
Mar 1, 2021
mwhicks1
approved these changes
Mar 1, 2021
mwhicks1
reviewed
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consists of
clang-format,clang-tidy, some plain old text wrapping using Emacs, and some ad-hoc tweaks. I'm happy with it but would welcome any scrutiny from others.A finer-grained (and messier) history is available here. I always run code style passes on 5C so that in case an element in 3C is renamed, any references in 5C get updated, but that didn't happen this time. Then I applied the overall 3C diff to 3C.
check-3cstill passes on Linux and Windows X86 and X64 andclangd3cstill builds. I think those are the important things.