Fix escaping bugs that currently affect the JSON formatting test on Windows. #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While I'm here, fix a typo in the name of json_formating.c and add `--` to its `3c` command lines.
mattmccutchen-cci
force-pushed
the
json-escaping-issue619
branch
from
e910cbd to
a9a7a14
Compare
mattmccutchen-cci
changed the base branch from
json-escaping-issue619.base
to
main
|
Aaron tested this PR on Mac OS and the new test does pass (I had been concerned that Mac OS might have a problem with the backslash in the filename), so I'm going to merge the PR. There are unrelated failures of other 3C regression tests on Mac OS that Aaron is still looking into. |
…nto json-escaping-issue619
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other escaping bugs may remain; #620 is to fix all of them.
Fixes #619.
This PR depends on #624 since it adds a second test of the JSON files and if we let both tests write JSON files directly in
build/tools/clang/test/3C, the tests could interfere if they are run in parallel. I've set the target branch for review purposes; I'll change it tomainafter #624 is merged.