No longer generate extra atoms to compare generic types #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This fixes the 0 atoms affected root cause in test root_cause.c
aaronjeline
requested changes
Aug 2, 2021
aaronjeline
reviewed
Aug 3, 2021
Co-authored-by: Aaron Eline <[email protected]>
|
This should be ready for review again, I believe I've addressed all the comments above. Let me know if there are still changes requested or if I'm good to merge. |
Co-authored-by: Matt McCutchen (Correct Computation) <[email protected]>
|
@aaronjeline I believe you still have an outstanding request for changes. Was there something else you asked me to do here or are we good to merge? |
|
Good to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, to compare function outputs with other constraints, we used the function's CV, which may have been generic. This made comparisons tricky, so extra atoms were added to fill out the type, but it resulted in over-constrained, no-longer-generic functions.
Now we use the type variable data already being collected to determine function output in a context-sensitive way. Most of this PR is about propagating that existing type variable information to other parts of the code-base.