Skip to content

metadataInIndex flag is broken #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bboreham opened this issue Nov 8, 2019 · 0 comments · Fixed by #1836
Closed

metadataInIndex flag is broken #1795

bboreham opened this issue Nov 8, 2019 · 0 comments · Fixed by #1836

Comments

@bboreham
Copy link
Contributor

bboreham commented Nov 8, 2019

Since @tomwilkie asked about this from the stage in PromCon...

As noted in #873:

The big casualty here is removing the support for metadataInIndex chunks

So we cannot read data written in 2016.

Given Chunk.metadataInIndex is never set we could remove all mention of it from the code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@bboreham