Skip to content

Potentially replace parts of Cortex's remote querying code with upstream code once it exists #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jml opened this issue Sep 9, 2016 · 3 comments
Assignees
Labels
type/chore Something that needs to be done; not a bug or a feature

Comments

@jml
Copy link
Contributor

jml commented Sep 9, 2016

From @tomwilkie

Could probably also be upstreamed.

Copied from original issue: tomwilkie/frankenstein#4

@juliusv
Copy link
Contributor

juliusv commented Jan 23, 2017

From email:

@rade:
Is this remote read-back feature what #5 is about? I thought it was but the issue is confusingly (to me) described as "remote query API" when querying cortex remotely is already possible today. So could somebody please add some clarification to that issue, one way or the other.

@juliusv:
I think that issue was more motivated by trying to upstream some of our own remote querying code so that we wouldn't have to maintain it ourselves. But it's strongly related to what would be needed upstream.

I'm going to create another issue for general remote queryability through Prometheus and rename this one.

@juliusv juliusv changed the title Remote query API Potentially replace parts of Cortex's remote querying code with upstream code once it exists Jan 23, 2017
@juliusv juliusv added type/chore Something that needs to be done; not a bug or a feature and removed type/feature labels Jan 23, 2017
@tomwilkie
Copy link
Contributor

The prometheus code does a bunch more work with external labels than we need to. Once #713 is merged, we're on all the same interfaces as upstream and I don't see much more work to do. Suggest we close.

@juliusv
Copy link
Contributor

juliusv commented Jul 12, 2018

Ok with me.

@juliusv juliusv closed this as completed Jul 12, 2018
roystchiang pushed a commit to roystchiang/cortex that referenced this issue Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Something that needs to be done; not a bug or a feature
Projects
None yet
Development

No branches or pull requests

4 participants