Switch to new-style rules format #622
Comments
|
I'm on this now. It needs some prep refactoring work because this change needs a vendored Prometheus version that includes prometheus/prometheus#3722, and that requires whole lot of other package compatibility changes in Cortex due to other unrelated updates in the Prometheus packages and their dependencies. |
juliusv
added a commit
that referenced
this issue
Feb 12, 2018
There's some trickiness here regarding what format to return from parsing, regarding the ability to track alert states, and not being able to create final rule groups yet. That's laid out in the comment above RulesConfig.Parse(). Fixes #622
juliusv
added a commit
that referenced
this issue
Mar 23, 2018
There's some trickiness here regarding what format to return from parsing, regarding the ability to track alert states, and not being able to create final rule groups yet. That's laid out in the comment above RulesConfig.Parse(). Fixes #622
juliusv
added a commit
that referenced
this issue
Apr 3, 2018
The rule format to use is now set binary-wide via the `-ruler.rule-format-version` and `configs.rule-format-version` flags, which still default to the Prometheus 1.x rule format. There's some trickiness here regarding what data type to return from parsing, regarding the ability to track alert states, and not being able to create final rule groups yet. That's laid out in the comment above RulesConfig.Parse(). Fixes #622
aknuds1
pushed a commit
to grafana/dskit
that referenced
this issue
Sep 2, 2021
The rule format to use is now set binary-wide via the `-ruler.rule-format-version` and `configs.rule-format-version` flags, which still default to the Prometheus 1.x rule format. There's some trickiness here regarding what data type to return from parsing, regarding the ability to track alert states, and not being able to create final rule groups yet. That's laid out in the comment above RulesConfig.Parse(). Fixes cortexproject/cortex#622
aknuds1
pushed a commit
to grafana/dskit
that referenced
this issue
Sep 2, 2021
The rule format to use is now set binary-wide via the `-ruler.rule-format-version` and `configs.rule-format-version` flags, which still default to the Prometheus 1.x rule format. There's some trickiness here regarding what data type to return from parsing, regarding the ability to track alert states, and not being able to create final rule groups yet. That's laid out in the comment above RulesConfig.Parse(). Fixes cortexproject/cortex#622
aknuds1
pushed a commit
to grafana/dskit
that referenced
this issue
Sep 7, 2021
The rule format to use is now set binary-wide via the `-ruler.rule-format-version` and `configs.rule-format-version` flags, which still default to the Prometheus 1.x rule format. There's some trickiness here regarding what data type to return from parsing, regarding the ability to track alert states, and not being able to create final rule groups yet. That's laid out in the comment above RulesConfig.Parse(). Fixes cortexproject/cortex#622
aknuds1
pushed a commit
to grafana/dskit
that referenced
this issue
Sep 8, 2021
The rule format to use is now set binary-wide via the `-ruler.rule-format-version` and `configs.rule-format-version` flags, which still default to the Prometheus 1.x rule format. There's some trickiness here regarding what data type to return from parsing, regarding the ability to track alert states, and not being able to create final rule groups yet. That's laid out in the comment above RulesConfig.Parse(). Fixes cortexproject/cortex#622
aknuds1
pushed a commit
to grafana/dskit
that referenced
this issue
Sep 8, 2021
The rule format to use is now set binary-wide via the `-ruler.rule-format-version` and `configs.rule-format-version` flags, which still default to the Prometheus 1.x rule format. There's some trickiness here regarding what data type to return from parsing, regarding the ability to track alert states, and not being able to create final rule groups yet. That's laid out in the comment above RulesConfig.Parse(). Fixes cortexproject/cortex#622
aknuds1
pushed a commit
to grafana/dskit
that referenced
this issue
Sep 9, 2021
The rule format to use is now set binary-wide via the `-ruler.rule-format-version` and `configs.rule-format-version` flags, which still default to the Prometheus 1.x rule format. There's some trickiness here regarding what data type to return from parsing, regarding the ability to track alert states, and not being able to create final rule groups yet. That's laid out in the comment above RulesConfig.Parse(). Fixes cortexproject/cortex#622
aknuds1
pushed a commit
to grafana/dskit
that referenced
this issue
May 26, 2023
The rule format to use is now set binary-wide via the `-ruler.rule-format-version` and `configs.rule-format-version` flags, which still default to the Prometheus 1.x rule format. There's some trickiness here regarding what data type to return from parsing, regarding the ability to track alert states, and not being able to create final rule groups yet. That's laid out in the comment above RulesConfig.Parse(). Fixes cortexproject/cortex#622
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prom 2 has a YAML syntax for defining alerting and recording rules. We should switch to that. I don't think we need backwards compatibility—we can probably get away with a one-off migration—but am open to differing opinions.
Mildly related to #619 (and thus #620).
CC @juliusv
The text was updated successfully, but these errors were encountered: