-
Notifications
You must be signed in to change notification settings - Fork 816
Integration test running ingesters #1271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
412c38c
to
17740e5
Compare
I am excited to see how this turns out. Also, if you want to make a PR for the avalanche work ping me in it and I will take a look. Since there seems to be some interest in Avalanche we will do some updates to it soon. |
5cb8146
to
c7a78d3
Compare
c7a78d3
to
9b18e44
Compare
6890fb5
to
817edb8
Compare
02ef633
to
54adb67
Compare
Signed-off-by: Bryan Boreham <[email protected]>
Signed-off-by: Bryan Boreham <[email protected]>
Running table-manager, distributors and ingesters, creating tables and running the hand-over process between ingesters. Signed-off-by: Bryan Boreham <[email protected]>
Signed-off-by: Bryan Boreham <[email protected]>
Need to move the 'images' directory to /tmp since /go isn't writeable in 'machine' executor type on CircleCI. Indirect via symlink so we can run the Makefile unchanged from the project directory. The Postgres container we were running seems to have been ignored, since the Makefile always runs another one. Signed-off-by: Bryan Boreham <[email protected]>
Shell variables don't persist from one Makefile line to the next, so we need to combine the commands into one line. Signed-off-by: Bryan Boreham <[email protected]>
Signed-off-by: Bryan Boreham <[email protected]>
Signed-off-by: Bryan Boreham <[email protected]>
1e8b420
to
e70b272
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with these as they are and look forward to having some high level tests.
I am curious, why sh
rather than using go?
integration-tests/test-flush.sh
Outdated
DIST_ADDR=$(container_ip distributor) | ||
wait_for "has_tokens_owned $DIST_ADDR" "distributor to see ingester in ring" | ||
|
||
docker run $RUN_ARGS --rm weaveworks/avalanche:remote-write --metric-count=2 --label-count=2 --series-count=2 --remote-url=http://distributor/api/prom/push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps use an upstream tag from: https://quay.io/repository/freshtracks.io/avalanche?tab=tags
I'm very used to working this way, from experience with Weave Net; it lets me iterate quickly. Part of it is I don't have a good framework in Go for starting processes, waiting for status, etc., and part I don't have a good toolset for interrupting Go programs, inspecting, status, re-running parts, etc. Happy to take suggestions for tooling. It's only 100 lines of shell script so should be possible to rewrite in Go in less than 1,000 😜 |
Available images need an additional flag to get same behaviour. Signed-off-by: Bryan Boreham <[email protected]>
A first cut. Attempting to keep things lightweight, e.g. no Kubernetes.
The test client is at https://github.com/bboreham/avalanche/tree/remote-write
You may say "that's an ugly pile of shell script, Bryan", and I might well agree with you.
It lets me iterate quickly.