Merged
Conversation
Contributor
tomwilkie
commented
Nov 11, 2016
tomwilkie
commented
- Don't gather account limits (needs more permissions)
- Don't collection anything by default: make it flag controlled (so we don't have to give permissions to ingester and distributor)
…tion anything by default: make it flag controlled (so we don't have to give permissions to ingester and distributor)
Contributor
Author
|
Will need post merge review #97 |
Contributor
|
Yes, fair enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.