Fix duration is zero #1334
Closed
Fix duration is zero #1334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When MaxBackoff not set, after one loop, duration is always bigger than it, so duration set as zero, then following panic occur: panic: invalid argument to Int63n goroutine 169 [running]: math/rand.(*Rand).Int63n(0xc0000cc150, 0x0, 0xc000719b58) /usr/lib/golang/src/math/rand/rand.go:111 +0x11e math/rand.Int63n(...) /usr/lib/golang/src/math/rand/rand.go:319 Signed-off-by: Xiang Dai <[email protected]>
|
How did you get into this situation? Backoff is meant to be used with non-zero parameters, so that it waits an increasing amount of time. I can't see what a zero-time delay would be good for. |
|
The key is to solve the panic, since i want even without set MaxBackoff, backoff could work without panic. |
|
I think it would be simpler to just put a check It's probably also unexpected that a zero minimum time with non-zero max time will result in zero waits. |
|
Do you mean min/max time is required field so no need to change here but check at caller? |
|
This has been overtaken by #1599 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When MaxBackoff not set, after one loop, duration is always bigger than
it, so duration set as zero, then following panic occur:
Signed-off-by: Xiang Dai [email protected]