Add context parameter to DB interface functions #1394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtlisi
changed the title
tomwilkie
reviewed
May 17, 2019
pkg/configs/client/client.go
Outdated
| @@ -119,20 +120,20 @@ type dbStore struct { | |||
| // GetRules implements ConfigClient. | |||
| func (d dbStore) GetRules(since configs.ID) (map[string]configs.VersionedRulesConfig, error) { | |||
There was a problem hiding this comment.
Can you add a context here too please?
There was a problem hiding this comment.
Yes, I wanted to wait til #1258 was merged so I could avoid more merge conflicts, but I'll add it here.
jtlisi
force-pushed
the
20190516_add_context_db_interface
branch
from
543ff25 to
b4e77b6
Compare
Signed-off-by: Jacob Lisi <[email protected]>
jtlisi
force-pushed
the
20190516_add_context_db_interface
branch
from
b4e77b6 to
d29fcb2
Compare
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not change the functionality of the DB in any way. It only passes the context as a parameter. I am working on an object store backend for rules files in GCS and want to pass a context variable. I also think it is useful to have the context in postgres if we want to add lower level instrumentation.
Signed-off-by: Jacob Lisi [email protected]