Skip to content

Expose table manager config for yaml #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2019
Merged

Expose table manager config for yaml #1400

merged 1 commit into from
May 21, 2019

Conversation

gouthamve
Copy link
Contributor

@gouthamve
Expose table manager config for yaml
547353d 
Signed-off-by: Goutham Veeramachaneni <[email protected]>
weeco
weeco approved these changes May 18, 2019
View reviewed changes
Copy link
Contributor

@weeco weeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

weeco
weeco reviewed May 18, 2019
View reviewed changes
pkg/chunk/table_manager.go

WriteScale AutoScalingConfig `yaml:"write_scale"`
InactiveWriteScale AutoScalingConfig `yaml:"inactive_write_scale"`
InactiveWriteScaleLastN int64 `yaml:"inactive_write_scale_lastn"`
Copy link
Contributor

@weeco weeco May 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add an underscore before the "n". This wayit would be consistent delimitation with the camelcase of the variable names. Not a big deal anyways

pkg/chunk/table_manager.go
InactiveWriteScaleLastN int64 `yaml:"inactive_write_scale_lastn"`
ReadScale AutoScalingConfig `yaml:"read_scale"`
InactiveReadScale AutoScalingConfig `yaml:"inactive_read_scale"`
InactiveReadScaleLastN int64 `yaml:"inactive_read_scale_lastn"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

khaines
khaines approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@khaines khaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gouthamve

@khaines khaines merged commit dee54bf into cortexproject:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weeco weeco weeco approved these changes

@khaines khaines khaines approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gouthamve @khaines @weeco