Add the ingester. prefix back to some flags
#1413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csmarchbanks
force-pushed
the
lifecycle-ingester-prefix
branch
from
693e231 to
4a6c277
Compare
csmarchbanks
changed the title
csmarchbanks
force-pushed
the
lifecycle-ingester-prefix
branch
from
4a6c277 to
755954b
Compare
csmarchbanks
changed the title
ingester. prefix back to some flags; update k8s/ manifests
csmarchbanks
force-pushed
the
lifecycle-ingester-prefix
branch
from
755954b to
fde1f25
Compare
bboreham
approved these changes
May 24, 2019
Many ingester flags were recently broken. This fixes the flags that were broken, but if anyone is running the new HA Ruler they will need to update their consul flags. Signed-off-by: Chris Marchbanks <[email protected]>
csmarchbanks
force-pushed
the
lifecycle-ingester-prefix
branch
from
fde1f25 to
d6aa67a
Compare
jtlisi
reviewed
May 24, 2019
csmarchbanks
force-pushed
the
lifecycle-ingester-prefix
branch
from
3bb9e66 to
b614a3f
Compare
This reverts commit d6aa67a. Signed-off-by: Chris Marchbanks <[email protected]>
Signed-off-by: Chris Marchbanks <[email protected]>
csmarchbanks
force-pushed
the
lifecycle-ingester-prefix
branch
from
b614a3f to
dad15af
Compare
csmarchbanks
changed the title
ingester. prefix back to some flags; update k8s/ manifestsingester. prefix back to some flags
|
Sorry about that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1258 got rid of the hardcoded
ingester.which broke an ingester upgrade for me today. Note that new flags likeruler.consul.hostnamewill not work after this.There is only one binary now, so use that in all the k8s/ manifests components.
Changes:
ingester.prefix againruler.consul.*flags will becomeconsul.*ruler.ring.heartbeat-timeoutandruler.distributor.replication-factorlose the ruler prefix (according to Jacob these are not needed for the ruler anyway)