Skip to content

Vendor update #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 7, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
24 changes: 9 additions & 15 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,15 @@ require (
github.com/gogo/status v1.0.3
github.com/golang/protobuf v1.3.1
github.com/golang/snappy v0.0.1
github.com/google/gofuzz v0.0.0-20161122191042-44d81051d367 // indirect
github.com/googleapis/gnostic v0.2.0 // indirect
github.com/gophercloud/gophercloud v0.0.0-20190307220656-fe1ba5ce12dd // indirect
github.com/gorilla/mux v1.6.2
github.com/gorilla/websocket v1.4.0 // indirect
github.com/grpc-ecosystem/go-grpc-middleware v1.0.1-0.20190118093823-f849b5445de4
github.com/hailocab/go-hostpool v0.0.0-20160125115350-e80d13ce29ed // indirect
github.com/hashicorp/consul v1.4.4
github.com/hashicorp/consul/api v1.1.0
github.com/hashicorp/go-cleanhttp v0.5.1
github.com/jonboulle/clockwork v0.1.0
github.com/json-iterator/go v1.1.5
github.com/json-iterator/go v1.1.6
github.com/konsorten/go-windows-terminal-sequences v1.0.2 // indirect
github.com/kylelemons/godebug v0.0.0-20170820004349-d65d576e9348 // indirect
github.com/lann/builder v0.0.0-20150808151131-f22ce00fd939 // indirect
Expand All @@ -46,22 +44,19 @@ require (
github.com/mattes/migrate v1.3.1
github.com/mattn/go-sqlite3 v1.10.0 // indirect
github.com/mgutz/ansi v0.0.0-20170206155736-9520e82c474b
github.com/mitchellh/go-homedir v1.1.0 // indirect
github.com/oklog/oklog v0.2.2 // indirect
github.com/oklog/oklog v0.3.2 // indirect
github.com/onsi/ginkgo v1.8.0 // indirect
github.com/onsi/gomega v1.5.0 // indirect
github.com/opentracing-contrib/go-grpc v0.0.0-20180928155321-4b5a12d3ff02
github.com/opentracing-contrib/go-stdlib v0.0.0-20170113013457-1de4cc2120e7
github.com/opentracing/opentracing-go v1.1.0
github.com/peterbourgon/diskv v2.0.1+incompatible // indirect
github.com/philhofer/fwd v0.0.0-20160129035939-98c11a7a6ec8 // indirect
github.com/pkg/errors v0.8.1
github.com/prometheus/alertmanager v0.13.0
github.com/prometheus/client_golang v0.9.3
github.com/prometheus/alertmanager v0.12.1-0.20190731170042-6e135a0112f5
github.com/prometheus/client_golang v1.0.0
github.com/prometheus/common v0.4.1
github.com/prometheus/procfs v0.0.1 // indirect
github.com/prometheus/prometheus v0.0.0-20190417125241-3cc5f9d88062
github.com/prometheus/tsdb v0.8.0
github.com/prometheus/prometheus v0.0.0-20190731144842-63ed2e28f1ac
github.com/prometheus/tsdb v0.9.1
github.com/segmentio/fasthash v0.0.0-20180216231524-a72b379d632e
github.com/sercand/kuberesolver v2.1.0+incompatible // indirect
github.com/sirupsen/logrus v1.4.2 // indirect
Expand All @@ -73,14 +68,14 @@ require (
github.com/uber/jaeger-client-go v2.16.0+incompatible
github.com/uber/jaeger-lib v2.0.0+incompatible // indirect
github.com/weaveworks/billing-client v0.0.0-20171006123215-be0d55e547b1
github.com/weaveworks/common v0.0.0-20190410110702-87611edc252e
github.com/weaveworks/common v0.0.0-20190714171817-ddeaa31513fd
github.com/weaveworks/mesh v0.0.0-20170131170447-5015f896ab62
github.com/weaveworks/promrus v1.2.0 // indirect
go.etcd.io/bbolt v1.3.3
go.etcd.io/etcd v0.0.0-20190709142735-eb7dd97135a5
go.uber.org/zap v1.10.0 // indirect
golang.org/x/crypto v0.0.0-20190530122614-20be4c3c3ed5 // indirect
golang.org/x/net v0.0.0-20190522155817-f3200d17e092
golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3
golang.org/x/sys v0.0.0-20190602015325-4c4f7f33c9ed // indirect
golang.org/x/text v0.3.2 // indirect
golang.org/x/time v0.0.0-20181108054448-85acf8d2951c
Expand All @@ -89,5 +84,4 @@ require (
google.golang.org/grpc v1.19.1
gopkg.in/fsnotify/fsnotify.v1 v1.4.7 // indirect
gopkg.in/yaml.v2 v2.2.2
k8s.io/klog v0.2.0 // indirect
)
132 changes: 67 additions & 65 deletions go.sum

Large diffs are not rendered by default.

11 changes: 10 additions & 1 deletion pkg/chunk/aws/metrics_autoscaling.go
Original file line number Diff line number Diff line change
Expand Up @@ -363,10 +363,19 @@ func promQuery(ctx context.Context, promAPI promV1.API, query string, duration,
Step: step,
}

value, err := promAPI.QueryRange(ctx, query, queryRange)
value, wrngs, err := promAPI.QueryRange(ctx, query, queryRange)
if err != nil {
return nil, err
}
if wrngs != nil {
level.Warn(util.Logger).Log(
"query", query,
"start", queryRange.Start,
"end", queryRange.End,
"step", queryRange.Step,
"warnings", wrngs,
)
}
matrix, ok := value.(model.Matrix)
if !ok {
return nil, fmt.Errorf("Unable to convert value to matrix: %#v", value)
Expand Down
7 changes: 4 additions & 3 deletions pkg/chunk/aws/metrics_autoscaling_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"time"

"github.com/pkg/errors"
"github.com/prometheus/client_golang/api"
promV1 "github.com/prometheus/client_golang/api/prometheus/v1"
"github.com/prometheus/common/model"

Expand Down Expand Up @@ -429,12 +430,12 @@ func (m *mockPrometheus) SetResponseForReads(usageRates [][]int, errorRates [][]
}
}

func (m *mockPrometheus) QueryRange(ctx context.Context, query string, r promV1.Range) (model.Value, error) {
func (m *mockPrometheus) QueryRange(ctx context.Context, query string, r promV1.Range) (model.Value, api.Warnings, error) {
if len(m.rangeValues) == 0 {
return nil, errors.New("mockPrometheus.QueryRange: out of values")
return nil, nil, errors.New("mockPrometheus.QueryRange: out of values")
}
// Take the first value and move the slice up
ret := m.rangeValues[0]
m.rangeValues = m.rangeValues[1:]
return ret, nil
return ret, nil, nil
}
3 changes: 2 additions & 1 deletion pkg/configs/configs.go
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,7 @@ func (c RulesConfig) parseV2() (map[string][]rules.Rule, error) {
time.Duration(rl.For),
labels.FromMap(rl.Labels),
labels.FromMap(rl.Annotations),
nil,
true,
log.With(util.Logger, "alert", rl.Alert),
))
Expand Down Expand Up @@ -262,7 +263,7 @@ func (c RulesConfig) parseV1() (map[string][]rules.Rule, error) {
}

rule = rules.NewAlertingRule(
r.Name, expr, r.Duration, r.Labels, r.Annotations, true,
r.Name, expr, r.Duration, r.Labels, r.Annotations, nil, true,
log.With(util.Logger, "alert", r.Name),
)

Expand Down
1 change: 1 addition & 0 deletions pkg/configs/configs_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ func TestParseLegacyAlerts(t *testing.T) {
labels.Labels{
labels.Label{Name: "message", Value: "I am a message"},
},
nil,
true,
log.With(util.Logger, "alert", "TestAlert"),
)
Expand Down
20 changes: 13 additions & 7 deletions pkg/configs/legacy_promql/engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -1297,13 +1297,17 @@ func (ev *evaluator) VectorBinop(op ItemType, lhs, rhs Vector, matching *VectorM
// signatureFunc returns a function that calculates the signature for a metric
// ignoring the provided labels. If on, then the given labels are only used instead.
func signatureFunc(on bool, names ...string) func(labels.Labels) uint64 {
// TODO(fabxc): ensure names are sorted and then use that and sortedness
// of labels by names to speed up the operations below.
// Alternatively, inline the hashing and don't build new label sets.
sort.Strings(names)
if on {
return func(lset labels.Labels) uint64 { return lset.HashForLabels(names...) }
return func(lset labels.Labels) uint64 {
h, _ := lset.HashForLabels(make([]byte, 0, 1024), names...)
return h
}
}
return func(lset labels.Labels) uint64 {
h, _ := lset.HashWithoutLabels(make([]byte, 0, 1024), names...)
return h
}
return func(lset labels.Labels) uint64 { return lset.HashWithoutLabels(names...) }
}

// resultMetric returns the metric for the given sample(s) based on the Vector
Expand Down Expand Up @@ -1503,6 +1507,8 @@ func (ev *evaluator) aggregation(op ItemType, grouping []string, without bool, p
}
}

sort.Strings(grouping)
buf := make([]byte, 0, 1024)
for _, s := range vec {
metric := s.Metric

Expand All @@ -1516,9 +1522,9 @@ func (ev *evaluator) aggregation(op ItemType, grouping []string, without bool, p
groupingKey uint64
)
if without {
groupingKey = metric.HashWithoutLabels(grouping...)
groupingKey, buf = metric.HashWithoutLabels(buf, grouping...)
} else {
groupingKey = metric.HashForLabels(grouping...)
groupingKey, buf = metric.HashForLabels(buf, grouping...)
}

group, ok := result[groupingKey]
Expand Down
8 changes: 5 additions & 3 deletions pkg/configs/legacy_promql/engine_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,11 @@ type errQuerier struct {
func (q *errQuerier) Select(*storage.SelectParams, ...*labels.Matcher) (storage.SeriesSet, storage.Warnings, error) {
return errSeriesSet{err: q.err}, nil, q.err
}
func (*errQuerier) LabelValues(name string) ([]string, error) { return nil, nil }
func (*errQuerier) LabelNames() ([]string, error) { return nil, nil }
func (*errQuerier) Close() error { return nil }
func (q *errQuerier) LabelValues(name string) ([]string, storage.Warnings, error) {
return nil, nil, q.err
}
func (q *errQuerier) LabelNames() ([]string, storage.Warnings, error) { return nil, nil, q.err }
func (q *errQuerier) Close() error { return q.err }

// errSeriesSet implements storage.SeriesSet which always returns error.
type errSeriesSet struct {
Expand Down
Loading