Set IMAGE_TAG to CIRCLE_TAG in Makefile #1551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Marchbanks <[email protected]>
bboreham
approved these changes
Aug 1, 2019
Contributor
bboreham
left a comment
bboreham
left a comment
There was a problem hiding this comment.
not the neatest thing in the world, but I guess it'll do
khaines
approved these changes
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are other steps in the build and deploy jobs that need IMAGE_TAG set to the CIRCLE_TAG. It will be easiest if the Makefile just knows to use CIRCLE_TAG if it is present.