Skip to content

Revert "Merge pull request #159 from weaveworks/protoring" #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2016

Conversation

tomwilkie
Copy link
Contributor

@tomwilkie tomwilkie commented Nov 26, 2016

There was a bug in the backwards compatibility with the old JSON, where the actual value of the token was getting dropped. This lead to the ring filling up, which was the bug we were trying to fix to begin with!

This reverts commit 79462f9, reversing
changes made to dfd6ab2.
@tomwilkie tomwilkie merged commit ece6907 into master Nov 26, 2016
@tomwilkie tomwilkie deleted the backout-protoring branch November 26, 2016 17:44
Copy link
Contributor

@jml jml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants