Ability to flush chunks with stale markers early. #1759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouthamve
force-pushed
the
flush-stale-chunks-early
branch
from
9562f8c to
2dcd68e
Compare
codesome
reviewed
Oct 25, 2019
bboreham
reviewed
Oct 25, 2019
gouthamve
force-pushed
the
flush-stale-chunks-early
branch
2 times, most recently
from
4f12eb8 to
5c84f37
Compare
|
@bboreham Using the lastSampleValue from memorySeries now, nice catch! Also added this to the docs. |
codesome
approved these changes
Oct 28, 2019
jtlisi
approved these changes
Oct 28, 2019
bboreham
reviewed
Oct 31, 2019
pracucci
reviewed
Oct 31, 2019
Signed-off-by: Goutham Veeramachaneni <[email protected]>
Signed-off-by: Goutham Veeramachaneni <[email protected]>
gouthamve
force-pushed
the
flush-stale-chunks-early
branch
from
93f1a54 to
2568855
Compare
bboreham
reviewed
Nov 5, 2019
| @@ -138,6 +139,7 @@ func (cfg *Config) RegisterFlags(f *flag.FlagSet) { | |||
| f.DurationVar(&cfg.RetainPeriod, "ingester.retain-period", 5*time.Minute, "Period chunks will remain in memory after flushing.") | |||
| f.DurationVar(&cfg.FlushOpTimeout, "ingester.flush-op-timeout", 1*time.Minute, "Timeout for individual flush operations.") | |||
| f.DurationVar(&cfg.MaxChunkIdle, "ingester.max-chunk-idle", 5*time.Minute, "Maximum chunk idle time before flushing.") | |||
| f.DurationVar(&cfg.MaxChunkIdle, "ingester.max-stale-chunk-idle", 0, "Maximum chunk idle time for chunks terminating in stale markers before flushing. 0 disables it and a stale series is not flushed until the max-chunk-idle timeout is reached.") | |||
There was a problem hiding this comment.
oops - typo MaxChunkIdle #1788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Goutham Veeramachaneni [email protected]