Skip to content

Export Unix timestamp of oldest unflushed chunk in the memory. #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pstibrany
Copy link
Contributor

This PR implements a simple addition: export of timestamp of oldest unflushed chunk in memory. This can be used for alerting, if timestamp is older than expected.

Fixes #1386

@gouthamve gouthamve requested a review from jtlisi November 4, 2019 11:11
@bboreham
Copy link
Contributor

bboreham commented Nov 4, 2019

I wonder if this information can be used to fix a thorny issue with ingester resilience, as described at #731 (comment)

(not 100% sure that is a valid fix, but it could be worth exploring)

Copy link
Contributor

@jtlisi jtlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gouthamve gouthamve merged commit 1f16b06 into cortexproject:master Nov 5, 2019
@gouthamve gouthamve deleted the 1386-export-oldest-chunk-timestamp branch November 5, 2019 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alerting on number of chunks per series is noisy
4 participants