If ingester.max-transfer-retries is set to 0, hand-over attempts are … #1777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…disabled. Due to interaction with BackOffConfig.MaxRetries, zero value meant infinite number of attempts, which is hardly ever a desired behaviour (with no ingester waiting to accept a transfer, this would never end). Fixed cortexproject#1771. Signed-off-by: Peter Štibraný <[email protected]>
gouthamve
approved these changes
Nov 4, 2019
Signed-off-by: Peter Štibraný <[email protected]>
pracucci
reviewed
Nov 4, 2019
There was a problem hiding this comment.
Good job @pstibrany. I just left a couple of small comments.
Signed-off-by: Peter Štibraný <[email protected]>
pracucci
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
-ingester.ingester.max-transfer-retriesis set to 0, hand-over attempts are disabled.Due to interaction with BackOffConfig.MaxRetries, zero value meant infinite number of attempts, which is hardly ever a desired behaviour (with no ingester waiting to accept a transfer, this would never end).
Fixed #1771.