Pass Request to DecodeResponse in case it is required. #1892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loki has the concept of log Direction which is essential to know when merging responses. This change allows Loki to inject the direction in the response which can be then used when merging multiple responses. Signed-off-by: Cyril Tovena <[email protected]>
cyriltovena
force-pushed
the
codec-loki
branch
from
c96fd0d to
b6a8f5e
Compare
bboreham
approved these changes
Dec 9, 2019
pracucci
approved these changes
Dec 10, 2019
| @@ -198,7 +198,7 @@ func (prometheusCodec) EncodeRequest(ctx context.Context, r Request) (*http.Requ | |||
| return req.WithContext(ctx), nil | |||
| } | |||
|
|
|||
| func (prometheusCodec) DecodeResponse(ctx context.Context, r *http.Response) (Response, error) { | |||
| func (prometheusCodec) DecodeResponse(ctx context.Context, r *http.Response, _ Request) (Response, error) { | |||
There was a problem hiding this comment.
I would suggest to add a comment to this function, explaining why we have _ Request, otherwise there's the risk we'll clean it up in the future because considered dead code.
There was a problem hiding this comment.
I added a note, but on the interface, I don't think here it matters.
Signed-off-by: Cyril Tovena <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loki has the concept of log Direction which is essential to know when
merging responses. This change allows Loki to inject the direction in the
response which can be then used when merging multiple responses.
Cortex doesn't need to use this.
Signed-off-by: Cyril Tovena [email protected]