-
Notifications
You must be signed in to change notification settings - Fork 847
Release 0.5.0 #1963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.5.0 #1963
Conversation
Signed-off-by: Goutham Veeramachaneni <[email protected]>
codesome
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.5.0-rc0 section in the CHANGELOG with the date is missing.
Signed-off-by: Goutham Veeramachaneni <[email protected]>
|
(Just a note that date needs to be changed in the CHANGELOG and RELEASE files before releasing) |
|
I suggest holding this release until someone can confirm that a 0.4-0.5 update with configs database works for them, unlike what I got at #1972 |
|
Needs to shout louder about the Ruler changes - I had to roll back because we had a single instance doing all the work and now we need to scale out. |
* Validate incoming labels for order and duplicate names. Signed-off-by: Peter Štibraný <[email protected]> * Document that cortex rejects requests with incorrectly ordered or duplicate labels. Signed-off-by: Peter Štibraný <[email protected]> * Ignore empty metric name. {__name__=""} will be shown formatted as {__name__=""} instead of just empty string. Signed-off-by: Peter Štibraný <[email protected]> * As we rely on sorted labels, sort them before using them. Signed-off-by: Peter Štibraný <[email protected]> * Updated CHANGELOG.md to reflect latest changes to PR. Signed-off-by: Peter Štibraný <[email protected]> * Put back redundant aliases. Signed-off-by: Peter Štibraný <[email protected]>
* wrap migration commands Signed-off-by: Jacob Lisi <[email protected]> * update changelog Signed-off-by: Jacob Lisi <[email protected]> * fix missing semicolon Signed-off-by: Jacob Lisi <[email protected]> * Fix typo to make lint pass. Signed-off-by: Goutham Veeramachaneni <[email protected]> Co-authored-by: Goutham Veeramachaneni <[email protected]>
Signed-off-by: Goutham Veeramachaneni <[email protected]>
be847c2 to
ce983fd
Compare
Signed-off-by: Goutham Veeramachaneni <[email protected]>
|
@bboreham @pracucci @tomwilkie @csmarchbanks @khaines Can we merge this in? I've merged master into it and made sure we didn't miss any PRs or changes. I think we can merge this into master and I'll send an email to the mailing list that we're abandoning the 0.5 release but will kick off 0.6 next week. |
Why did you merge master to this branch? I think that it just creates weird log history, and merging release branch to master would be enough. |
|
There were conflicts, I didn't want to resolve them via the UI and there
was no way to push to master from my local. I didn't see another way other
than the merge.
…On Thu, Jan 16, 2020 at 8:28 PM Peter Štibraný ***@***.***> wrote:
Can we merge this in? I've merged master into it and made sure we didn't
miss any PRs or changes.
Why did you merge master to this branch? I think that it just creates
weird log history, and merging release branch to master would be enough.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1963?email_source=notifications&email_token=ABYDOHZVZBE6PMEZAFDF3HDQ6C7N7A5CNFSM4KEHKZJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJFN56Y#issuecomment-575332091>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABYDOH6424ND3LGDPJAWSITQ6C7N7ANCNFSM4KEHKZJQ>
.
|
ok, I see. Perhaps rebasing would be another option, but that’s very atypical modification for release branch. |
|
Yeah don't want to force push to the release branch, some of the commits have been tagged. |
pracucci
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a nit.
RELEASE.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update this and mention it has been abandoned.
Signed-off-by: Goutham Veeramachaneni <[email protected]>
Signed-off-by: Goutham Veeramachaneni <[email protected]>
fb0def4 to
1495812
Compare
I've gone through the history and the changelog is updated. One thing missing from it is #1750 but I've decided to explicitly exclude it until we have the WAL pieces and a guide to use the WAL documented.
It has been too long since 0.4.0 and I think it's time we get another release out. I know we thought of doing 1.0 but I don't have enough time to work on it yet and it's best done as the next release.