Skip to content

Conversation

@gouthamve
Copy link
Contributor

I've gone through the history and the changelog is updated. One thing missing from it is #1750 but I've decided to explicitly exclude it until we have the WAL pieces and a guide to use the WAL documented.

It has been too long since 0.4.0 and I think it's time we get another release out. I know we thought of doing 1.0 but I don't have enough time to work on it yet and it's best done as the next release.

Signed-off-by: Goutham Veeramachaneni <[email protected]>
Copy link
Contributor

@codesome codesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.5.0-rc0 section in the CHANGELOG with the date is missing.

Signed-off-by: Goutham Veeramachaneni <[email protected]>
@codesome
Copy link
Contributor

codesome commented Jan 9, 2020

(Just a note that date needs to be changed in the CHANGELOG and RELEASE files before releasing)

@bboreham
Copy link
Contributor

I suggest holding this release until someone can confirm that a 0.4-0.5 update with configs database works for them, unlike what I got at #1972

@bboreham
Copy link
Contributor

Needs to shout louder about the Ruler changes - I had to roll back because we had a single instance doing all the work and now we need to scale out.

pstibrany and others added 3 commits January 15, 2020 11:51
* Validate incoming labels for order and duplicate names.

Signed-off-by: Peter Štibraný <[email protected]>

* Document that cortex rejects requests with incorrectly ordered or duplicate labels.

Signed-off-by: Peter Štibraný <[email protected]>

* Ignore empty metric name.

{__name__=""} will be shown formatted as {__name__=""} instead of just empty string.

Signed-off-by: Peter Štibraný <[email protected]>

* As we rely on sorted labels, sort them before using them.

Signed-off-by: Peter Štibraný <[email protected]>

* Updated CHANGELOG.md to reflect latest changes to PR.

Signed-off-by: Peter Štibraný <[email protected]>

* Put back redundant aliases.

Signed-off-by: Peter Štibraný <[email protected]>
* wrap migration commands

Signed-off-by: Jacob Lisi <[email protected]>

* update changelog

Signed-off-by: Jacob Lisi <[email protected]>

* fix missing semicolon

Signed-off-by: Jacob Lisi <[email protected]>

* Fix typo to make lint pass.

Signed-off-by: Goutham Veeramachaneni <[email protected]>

Co-authored-by: Goutham Veeramachaneni <[email protected]>
Signed-off-by: Goutham Veeramachaneni <[email protected]>
@gouthamve gouthamve changed the title Release 0.5.0-rc0 Release 0.5.0 Jan 15, 2020
Signed-off-by: Goutham Veeramachaneni <[email protected]>
@gouthamve
Copy link
Contributor Author

@bboreham @pracucci @tomwilkie @csmarchbanks @khaines

Can we merge this in? I've merged master into it and made sure we didn't miss any PRs or changes. I think we can merge this into master and I'll send an email to the mailing list that we're abandoning the 0.5 release but will kick off 0.6 next week.

@pstibrany
Copy link
Contributor

Can we merge this in? I've merged master into it and made sure we didn't miss any PRs or changes.

Why did you merge master to this branch? I think that it just creates weird log history, and merging release branch to master would be enough.

@gouthamve
Copy link
Contributor Author

gouthamve commented Jan 16, 2020 via email

@pstibrany
Copy link
Contributor

and there was no way to push to master from my local

ok, I see. Perhaps rebasing would be another option, but that’s very atypical modification for release branch.

@gouthamve
Copy link
Contributor Author

Yeah don't want to force push to the release branch, some of the commits have been tagged.

Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a nit.

RELEASE.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update this and mention it has been abandoned.

Signed-off-by: Goutham Veeramachaneni <[email protected]>
Signed-off-by: Goutham Veeramachaneni <[email protected]>
@gouthamve gouthamve merged commit 2cc8d07 into master Jan 17, 2020
@gouthamve gouthamve deleted the release-0.5 branch January 17, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants