Remove remaining support for denormalised tokens in the ring. #2034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
…tex. Signed-off-by: Peter Štibraný <[email protected]>
jtlisi
approved these changes
Jan 27, 2020
jtlisi
reviewed
Jan 27, 2020
Signed-off-by: Peter Štibraný <[email protected]>
We don't expect to run a mix of old (with old fields) and new (with new field with the same number) Cortex versions in practice. Signed-off-by: Peter Štibraný <[email protected]>
pracucci
reviewed
Jan 28, 2020
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
|
Thank you both for your reviews. I've addressed (hopefully all) your feedback.
Btw, we have integration test doing this already (it found some bugs in my code in the past). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes remaining support for denormalised tokens in the ring.
Targeted for post 0.6 release.
Reason for this change is to simplify the code. Nobody should be using denormalised tokens anymore, we have provided smooth upgrade path (post 0.4.0 Cortex only writes normalised tokens).
As we don't expect to run a mix of old (with old fields in ring protobuf) and new (with some new field with the same number) Cortex versions in practice, I've removed reserved fields from ring protobuf and also didn't reserve number for just-removed
Tokensfield.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]