HTTP over gRPC: encode HTTP requests as gRPC requests #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwilkie
force-pushed
the
http-over-grpc
branch
from
892a4df to
264c489
Compare
juliusv
reviewed
Jan 24, 2017
| } | ||
| req = req.WithContext(ctx) | ||
| req.Header = toHeader(r.Headers) | ||
| recorder := httptest.NewRecorder() |
|
👍 crazy stuff. |
tomwilkie
force-pushed
the
http-over-grpc
branch
2 times, most recently
from
c96a023 to
d1758d0
Compare
tomwilkie
changed the title
jml
approved these changes
Jan 26, 2017
Why? Want to use gRPC for everything, as it make propagating context, load balacing and connection persisting easier than using raw HTTP.
By embedding HTTP in gRPC, we have a migration path, and a way for authfe to no have to know how to forward requests for every service type.
Also, move user context code and grpc middleware to weaveworks/common, remove scope vendoring.
tomwilkie
force-pushed
the
http-over-grpc
branch
from
d1758d0 to
002d2c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? Want to use gRPC for everything, as it make propagating context, load balacing and connection persisting easier than using raw HTTP.
By embedding HTTP in gRPC, we have a migration path, and a way for authfe to no have to know how to forward requests for every service type.
See weaveworks/common#10 for the PR to add this to common, which should go in first.