-
Notifications
You must be signed in to change notification settings - Fork 816
Add redis and inmemory cache backend for blocks storage #3573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a0caf20
to
15fd4f2
Compare
I have some questions.
|
620aa49
to
0dec19e
Compare
I believe there is an ongoing work in Thanos to move (I cannot find an issue for it though. I think it is being done by @Sudhar287 as part of thanos-io/thanos#3408, but I may be confusing the two, and it may in fact be unrelated.) |
d6f4239
to
9b601fb
Compare
Since the related PR is closed, work will resume. I also added an InMemory implementation to the cache. |
51c55a3
to
eec980e
Compare
5d68b8a
to
6964a28
Compare
Signed-off-by: kamijin_fanta <[email protected]>
Signed-off-by: kamijin_fanta <[email protected]>
6964a28
to
2af9256
Compare
This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions. |
I think this is an interesting option. Are we going to go forward with this? |
@kamijin-fanta @pstibrany @pracucci can we re-open this pr? redis is also very popular and should be an alternative besides memcached. |
What this PR does:
-blocks-storage.bucket-store.index-cache.backend=redis
-blocks-storage.bucket-store.index-cache.redis.*
-blocks-storage.bucket-store.metadata-cache.backend=redis
-blocks-storage.bucket-store.metadata-cache.redis.*
-blocks-storage.bucket-store.chunks-cache.backend.backend=redis
-blocks-storage.bucket-store.chunks-cache.backend.redis.*
-blocks-storage.bucket-store.metadata-cache.inmemory.*
-blocks-storage.bucket-store.chunks-cache.inmemory.*
Which issue(s) this PR fixes:
fix #3568
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]